netdev - Re: [PATCH net 1/2] ipv6: add missing netconf notif when 'all' is updated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <705293f5-0965-8d1c-1539-b70cbed6aea9@cogentembedded.com>
Date:   Mon, 29 Aug 2016 16:00:38 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Nicolas Dichtel <nicolas.dichtel@...nd.com>, davem@...emloft.net
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net 1/2] ipv6: add missing netconf notif when 'all' is
 updated

Hello.

On 8/29/2016 1:05 PM, Nicolas Dichtel wrote:

> The 'default' value was not advertised.
>
> Fixes: f3a1bfb11ccb ("rtnl/ipv6: use netconf msg to advertise forwarding status")
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
> ---
>  net/ipv6/addrconf.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> index f418d2eaeddd..299f0656e87f 100644
> --- a/net/ipv6/addrconf.c
> +++ b/net/ipv6/addrconf.c
> @@ -778,7 +778,14 @@ static int addrconf_fixup_forwarding(struct ctl_table *table, int *p, int newf)
>  	}
>
>  	if (p == &net->ipv6.devconf_all->forwarding) {
> +		int old_dftl = net->ipv6.devconf_dflt->forwarding;
> +
>  		net->ipv6.devconf_dflt->forwarding = newf;
> +		if ((!newf) ^ (!old_dftl))

    IIUC, !'s are not necessary here (and more so the parens around them). And 
perhaps ^ can be changed to != for clarity...

> +			inet6_netconf_notify_devconf(net, NETCONFA_FORWARDING,
> +						     NETCONFA_IFINDEX_DEFAULT,
> +						     net->ipv6.devconf_dflt);
> +
>  		addrconf_forward_change(net, newf);
>  		if ((!newf) ^ (!old))
>  			inet6_netconf_notify_devconf(net, NETCONFA_FORWARDING,

MBR, Sergei