netdev - Re: [PATCH net 1/2] ipv6: add missing netconf notif when 'all' is updated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9bb74290-07d9-8b7b-a039-7005f3b10cea@6wind.com>
Date:   Mon, 29 Aug 2016 15:42:56 +0200
From:   Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        davem@...emloft.net
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net 1/2] ipv6: add missing netconf notif when 'all' is
 updated

Le 29/08/2016 à 15:00, Sergei Shtylyov a écrit :
[snip]
>>      if (p == &net->ipv6.devconf_all->forwarding) {
>> +        int old_dftl = net->ipv6.devconf_dflt->forwarding;
>> +
>>          net->ipv6.devconf_dflt->forwarding = newf;
>> +        if ((!newf) ^ (!old_dftl))
> 
>    IIUC, !'s are not necessary here (and more so the parens around them). And
> perhaps ^ can be changed to != for clarity...
Yes, but a lot of places in this code use that. So for consistency I use the same.

> 
>> +            inet6_netconf_notify_devconf(net, NETCONFA_FORWARDING,
>> +                             NETCONFA_IFINDEX_DEFAULT,
>> +                             net->ipv6.devconf_dflt);
>> +
>>          addrconf_forward_change(net, newf);
>>          if ((!newf) ^ (!old))
Here is an example.