netdev - Re: [PATCH net-next V4 3/4] net/sched: cls_flower: Classify packet in ip tunnels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160831151238.GC1986@nanopsycho>
Date:   Wed, 31 Aug 2016 17:12:38 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Hadar Hen Zion <hadarh@...lanox.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Jiri Pirko <jiri@...lanox.com>, Jiri Benc <jbenc@...hat.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Shmulik Ladkani <shmulik.ladkani@...il.com>,
        Tom Herbert <tom@...bertland.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Or Gerlitz <ogerlitz@...lanox.com>,
        Amir Vadai <amirva@...lanox.com>, Amir Vadai <amir@...ai.me>
Subject: Re: [PATCH net-next V4 3/4] net/sched: cls_flower: Classify packet
 in ip tunnels

Wed, Aug 31, 2016 at 02:46:23PM CEST, hadarh@...lanox.com wrote:
>From: Amir Vadai <amir@...ai.me>
>
>Introduce classifying by metadata extracted by the tunnel device.
>Outer header fields - source/dest ip and tunnel id, are extracted from
>the metadata when classifying.
>
>For example, the following will add a filter on the ingress Qdisc of shared
>vxlan device named 'vxlan0'. To forward packets with outer src ip
>11.11.0.2, dst ip 11.11.0.1 and tunnel id 11. The packets will be
>forwarded to tap device 'vnet0' (after metadata is released):
>
>$ filter add dev vxlan0 protocol ip parent ffff: \
>    flower \
>      enc_src_ip 11.11.0.2 \
>      enc_dst_ip 11.11.0.1 \
>      enc_key_id 11 \
>      dst_ip 11.11.11.1 \
>    action tunnel_key release \
>    action mirred egress redirect dev vnet0
>
>The action tunnel_key, will be introduced in the next patch in this
>series.
>
>Signed-off-by: Amir Vadai <amir@...ai.me>
>Signed-off-by: Hadar Hen Zion <hadarh@...lanox.com>
>---
> include/uapi/linux/pkt_cls.h |  11 +++++
> net/sched/cls_flower.c       | 101 ++++++++++++++++++++++++++++++++++++++++++-
> 2 files changed, 110 insertions(+), 2 deletions(-)
>

<snip>	
	
>@@ -345,7 +382,6 @@ static int fl_set_key(struct net *net, struct nlattr **tb,
> 		mask->indev_ifindex = 0xffffffff;
> 	}
> #endif
>-
> 	fl_set_key_val(tb, key->eth.dst, TCA_FLOWER_KEY_ETH_DST,
> 		       mask->eth.dst, TCA_FLOWER_KEY_ETH_DST_MASK,
> 		       sizeof(key->eth.dst));


Please remove this hunk. Other than that,

Acked-by: Jiri Pirko <jiri@...lanox.com>