netdev - Re: [PATCH net-next V4 4/4] net/sched: Introduce act_tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160831153933.GD1986@nanopsycho>
Date:   Wed, 31 Aug 2016 17:39:33 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Hadar Hen Zion <hadarh@...lanox.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Jiri Pirko <jiri@...lanox.com>, Jiri Benc <jbenc@...hat.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Shmulik Ladkani <shmulik.ladkani@...il.com>,
        Tom Herbert <tom@...bertland.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Or Gerlitz <ogerlitz@...lanox.com>,
        Amir Vadai <amirva@...lanox.com>, Amir Vadai <amir@...ai.me>
Subject: Re: [PATCH net-next V4 4/4] net/sched: Introduce act_tunnel_key

Wed, Aug 31, 2016 at 02:46:24PM CEST, hadarh@...lanox.com wrote:
>From: Amir Vadai <amir@...ai.me>
>
>This action could be used before redirecting packets to a shared tunnel
>device, or when redirecting packets arriving from a such a device.
>
>The action will release the metadata created by the tunnel device
>(decap), or set the metadata with the specified values for encap
>operation.
>
>For example, the following flower filter will forward all ICMP packets
>destined to 11.11.11.2 through the shared vxlan device 'vxlan0'. Before
>redirecting, a metadata for the vxlan tunnel is created using the
>tunnel_key action and it's arguments:
>
>$ filter add dev net0 protocol ip parent ffff: \
>    flower \
>      ip_proto 1 \
>      dst_ip 11.11.11.2 \
>    action tunnel_key set \
>      src_ip 11.11.0.1 \
>      dst_ip 11.11.0.2 \
>      id 11 \
>    action mirred egress redirect dev vxlan0
>
>Signed-off-by: Amir Vadai <amir@...ai.me>
>Signed-off-by: Hadar Hen Zion <hadarh@...lanox.com>


Looks fine to me
Reviewed-by: Jiri Pirko <jiri@...lanox.com>