netdev - Re: [RFC] xgbe: constify get_netdev_ops and get_ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160831.141750.55012883444641424.davem@davemloft.net>
Date:   Wed, 31 Aug 2016 14:17:50 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     stephen@...workplumber.org
Cc:     Julia.Lawall@...6.fr, thomas.lendacky@....com,
        netdev@...r.kernel.org
Subject: Re: [RFC] xgbe: constify get_netdev_ops and get_ethtool_ops

From: Stephen Hemminger <stephen@...workplumber.org>
Date: Wed, 31 Aug 2016 08:57:36 -0700

> Casting away const is bad practice. Since this is ARM specific driver
> don't have hardware actually test this.
> 
> Having getter functions for ops is really unnecessary code bloat, but
> not going to touch that.
> 
> Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>

I'll just apply this, let's see what happens.