netdev - Re: [RFC] xgbe: constify get_netdev_ops and get_ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b4dedd72-8c15-2873-e471-8cb5a5485ded@amd.com>
Date:   Wed, 31 Aug 2016 19:50:32 -0500
From:   Tom Lendacky <thomas.lendacky@....com>
To:     David Miller <davem@...emloft.net>, <stephen@...workplumber.org>
CC:     <Julia.Lawall@...6.fr>, <netdev@...r.kernel.org>
Subject: Re: [RFC] xgbe: constify get_netdev_ops and get_ethtool_ops

On 08/31/2016 04:17 PM, David Miller wrote:
> From: Stephen Hemminger <stephen@...workplumber.org>
> Date: Wed, 31 Aug 2016 08:57:36 -0700
> 
>> Casting away const is bad practice. Since this is ARM specific driver
>> don't have hardware actually test this.
>>
>> Having getter functions for ops is really unnecessary code bloat, but
>> not going to touch that.
>>
>> Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>
> 
> I'll just apply this, let's see what happens.

I should be able to test this in the next few days. I don't expect there
to be an issue. I'll let you know what I find.

Thanks,
Tom

>