netdev - Re: [RFC] xgbe: constify get_netdev_ops and get_ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <feff89c8-d08b-e4ab-f260-ed274910c6d9@amd.com>
Date:   Thu, 1 Sep 2016 12:45:13 -0500
From:   Tom Lendacky <thomas.lendacky@....com>
To:     David Miller <davem@...emloft.net>, <stephen@...workplumber.org>
CC:     <Julia.Lawall@...6.fr>, <netdev@...r.kernel.org>
Subject: Re: [RFC] xgbe: constify get_netdev_ops and get_ethtool_ops

On 08/31/2016 07:50 PM, Tom Lendacky wrote:
> On 08/31/2016 04:17 PM, David Miller wrote:
>> From: Stephen Hemminger <stephen@...workplumber.org>
>> Date: Wed, 31 Aug 2016 08:57:36 -0700
>>
>>> Casting away const is bad practice. Since this is ARM specific driver
>>> don't have hardware actually test this.
>>>
>>> Having getter functions for ops is really unnecessary code bloat, but
>>> not going to touch that.
>>>
>>> Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>
>>
>> I'll just apply this, let's see what happens.
> 
> I should be able to test this in the next few days. I don't expect there
> to be an issue. I'll let you know what I find.

No issues found in build and test. For what it's worth since the patch
is already applied:

Tested-by: Tom Lendacky <thomas.lendacky@....com>

> 
> Thanks,
> Tom
> 
>>