netdev - Re: [PATCH] qed: fix kzalloc-simple.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160901.094813.947883991894136945.davem@davemloft.net>
Date:   Thu, 01 Sep 2016 09:48:13 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     Yuval.Mintz@...gic.com
Cc:     fengguang.wu@...el.com, kbuild-all@...org, netdev@...r.kernel.org,
        Ariel.Elior@...gic.com, Dept-EngEverestLinuxL2@...gic.com,
        linux-kernel@...r.kernel.org, Sudarsana.Kalluru@...gic.com
Subject: Re: [PATCH] qed: fix kzalloc-simple.cocci warnings

From: Yuval Mintz <Yuval.Mintz@...gic.com>
Date: Thu, 1 Sep 2016 07:37:13 +0000

>> drivers/net/ethernet/qlogic/qed/qed_dcbx.c:1230:13-20: WARNING: kzalloc
>> should be used for dcbx_info, instead of kmalloc/memset
>> drivers/net/ethernet/qlogic/qed/qed_dcbx.c:1192:13-20: WARNING: kzalloc
>> should be used for dcbx_info, instead of kmalloc/memset
>> 
>> 
>>  Use kzalloc rather than kmalloc followed by memset with 0
>> 
>>  This considers some simple cases that are common and easy to validate  Note in
>> particular that there are no ...s in the rule, so all of the  matched code has to be
>> contiguous
>> 
>> Generated by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
>> 
>> CC: Sudarsana Reddy Kalluru <sudarsana.kalluru@...gic.com>
>> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> 
> This looks fine; But what's the right process here -
> Dave - do we need to re-post this with the the right 'destination' in title
> [net/net-next]? Or is it good as-is?
> In case of latter,
> Acked-by: Yuval Mintz <Yuval.Mintz@...gic.com>

I'll apply this as-is, thanks.