netdev - RE: [PATCH] qed: fix kzalloc-simple.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM5PR11MB1723927908802E0D1C38C94D97E20@DM5PR11MB1723.namprd11.prod.outlook.com>
Date:   Thu, 1 Sep 2016 07:37:13 +0000
From:   Yuval Mintz <Yuval.Mintz@...gic.com>
To:     kbuild test robot <fengguang.wu@...el.com>,
        David Miller <davem@...emloft.net>
CC:     "kbuild-all@...org" <kbuild-all@...org>,
        netdev <netdev@...r.kernel.org>,
        Ariel Elior <Ariel.Elior@...gic.com>,
        Dept-Eng Everest Linux L2 <Dept-EngEverestLinuxL2@...gic.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Sudarsana Kalluru <Sudarsana.Kalluru@...gic.com>
Subject: RE: [PATCH] qed: fix kzalloc-simple.cocci warnings

> drivers/net/ethernet/qlogic/qed/qed_dcbx.c:1230:13-20: WARNING: kzalloc
> should be used for dcbx_info, instead of kmalloc/memset
> drivers/net/ethernet/qlogic/qed/qed_dcbx.c:1192:13-20: WARNING: kzalloc
> should be used for dcbx_info, instead of kmalloc/memset
> 
> 
>  Use kzalloc rather than kmalloc followed by memset with 0
> 
>  This considers some simple cases that are common and easy to validate  Note in
> particular that there are no ...s in the rule, so all of the  matched code has to be
> contiguous
> 
> Generated by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
> 
> CC: Sudarsana Reddy Kalluru <sudarsana.kalluru@...gic.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>

This looks fine; But what's the right process here -
Dave - do we need to re-post this with the the right 'destination' in title
[net/net-next]? Or is it good as-is?
In case of latter,
Acked-by: Yuval Mintz <Yuval.Mintz@...gic.com>

One question the automated script -
Can't it [relative] easily be upgraded to also have 'Fixes:' as part of its message?