netdev - Re: [PATCH net-next 6/6] net/mlx5: Add handling for port module event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57C6B9F7.306@mellanox.com>
Date:   Wed, 31 Aug 2016 14:05:27 +0300
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     Or Gerlitz <gerlitz.or@...il.com>
CC:     "David S. Miller" <davem@...emloft.net>,
        Linux Netdev List <netdev@...r.kernel.org>,
        Huy Nguyen <huyn@...lanox.com>
Subject: Re: [PATCH net-next 6/6] net/mlx5: Add handling for port module event



On 8/30/2016 11:24 PM, Or Gerlitz wrote:
> On Tue, Aug 30, 2016 at 2:29 PM, Saeed Mahameed <saeedm@...lanox.com> wrote:
>> From: Huy Nguyen <huyn@...lanox.com>
>> +++ b/include/linux/mlx5/device.h
>> @@ -543,6 +544,15 @@ struct mlx5_eqe_vport_change {
>>          __be32          rsvd1[6];
>>   } __packed;
>>
>> +struct mlx5_eqe_port_module {
>> +       u8        rsvd0[1];
>> +       u8        module;
>> +       u8        rsvd1[1];
>> +       u8        module_status;
>> +       u8        rsvd2[2];
>> +       u8        error_type;
>> +};
>> +
> Saeed, any reason for this struct and friends not to be  @ the FW IFC file?

Yes, those structures are accessed from irq context, we need to keep it 
as fast as possible,
although for this case it is not that critical. But in order to keep the 
code uniform, all eqes are built this way.