netdev - Re: [PATCH net v2] tg3: Fix for disallow tx coalescing time to be 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160901.095809.1791445078754790512.davem@davemloft.net>
Date:   Thu, 01 Sep 2016 09:58:09 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ivecera@...hat.com
Cc:     netdev@...r.kernel.org, satish.baddipadige@...adcom.com,
        siva.kallam@...adcom.com, michael.chan@...adcom.com
Subject: Re: [PATCH net v2] tg3: Fix for disallow tx coalescing time to be 0

From: Ivan Vecera <ivecera@...hat.com>
Date: Thu,  1 Sep 2016 11:28:59 +0200

> The recent commit 087d7a8c9174 "tg3: Fix for diasllow rx coalescing
> time to be 0" disallow to set Rx coalescing time to be 0 as this stops
> generating interrupts for the incoming packets. I found the zero
> Tx coalescing time stops generating interrupts for outgoing packets
> as well and fires Tx watchdog later. To avoid this, don't allow to set
> Tx coalescing time to 0 and also remove subsequent checks that become
> senseless.
> 
> Cc: satish.baddipadige@...adcom.com
> Cc: siva.kallam@...adcom.com
> Cc: michael.chan@...adcom.com
> Signed-off-by: Ivan Vecera <ivecera@...hat.com>

Applied.