netdev - Re: [PATCH net v1] tipc: fix random link resets while adding a second bearer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160901.101328.782876070935686176.davem@davemloft.net>
Date:   Thu, 01 Sep 2016 10:13:28 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     parthasarathy.bhuvaragan@...csson.com
Cc:     netdev@...r.kernel.org, tipc-discussion@...ts.sourceforge.net,
        jon.maloy@...csson.com, maloy@...jonn.com, ying.xue@...driver.com
Subject: Re: [PATCH net v1] tipc: fix random link resets while adding a
 second bearer

From: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@...csson.com>
Date: Thu, 1 Sep 2016 16:22:16 +0200

> In a dual bearer configuration, if the second tipc link becomes
> active while the first link still has pending nametable "bulk"
> updates, it randomly leads to reset of the second link.
> 
> When a link is established, the function named_distribute(),
> fills the skb based on node mtu (allows room for TUNNEL_PROTOCOL)
> with NAME_DISTRIBUTOR message for each PUBLICATION.
> However, the function named_distribute() allocates the buffer by
> increasing the node mtu by INT_H_SIZE (to insert NAME_DISTRIBUTOR).
> This consumes the space allocated for TUNNEL_PROTOCOL.
> 
> When establishing the second link, the link shall tunnel all the
> messages in the first link queue including the "bulk" update.
> As size of the NAME_DISTRIBUTOR messages while tunnelling, exceeds
> the link mtu the transmission fails (-EMSGSIZE).
> 
> Thus, the synch point based on the message count of the tunnel
> packets is never reached leading to link timeout.
> 
> In this commit, we adjust the size of name distributor message so that
> they can be tunnelled.
> 
> Reviewed-by: Jon Maloy <jon.maloy@...csson.com>
> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@...csson.com>

Applied.