netdev - Re: [net-next PATCH] e1000: add initial XDP support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57C88279.4030701@gmail.com>
Date:   Thu, 1 Sep 2016 12:33:13 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     Jamal Hadi Salim <jhs@...atatu.com>,
        Jesper Dangaard Brouer <brouer@...hat.com>
Cc:     bblanco@...mgrid.com, davem@...emloft.net,
        alexei.starovoitov@...il.com, john.r.fastabend@...el.com,
        netdev@...r.kernel.org, xiyou.wangcong@...il.com
Subject: Re: [net-next PATCH] e1000: add initial XDP support

[...]

> I think given how ancient the e1000 is we may see the driver being
> a contributing overhead. I believe XDP given location will do
> well - but for this kind of driver my gut feeling is probably not
> by large margin.
> 

Right so just ran the baseline, xdp, tc spread and its all more or
less in the noise where you drop the packets doesn't matter much. At
least in my setup where I'm running e1000 in a VM backed by a tap
device. I don't have a physical e1000 in my system at the moment to
test.

I still think this code is valuable though because it lets me run
the same XDP program in a e1000 VM that I'm running on my 10/40Gbps
NIC. Also it gives me a nice test platform to work on.

I'm going to resubmit the patch with a couple of the fixes pointed out
by others.

Thanks,
John