netdev - Re: [net] i40e: Fix kernel panic on enable/disable LLDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160901.142045.1724169627272941166.davem@davemloft.net>
Date:   Thu, 01 Sep 2016 14:20:45 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jeffrey.t.kirsher@...el.com
Cc:     david.m.ertman@...el.com, netdev@...r.kernel.org,
        nhorman@...hat.com, sassmann@...hat.com, jogreene@...hat.com,
        guru.anbalagane@...cle.com
Subject: Re: [net] i40e: Fix kernel panic on enable/disable LLDP

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Mon, 29 Aug 2016 17:38:26 -0700

> From: Dave Ertman <david.m.ertman@...el.com>
> 
> If DCB is configured on the link partner switch with an
> unsupported traffic class configuration (e.g. non-contiguous TCs),
> the driver is flagging DCB as disabled.  But, for future DCB
> LLDPDUs, the driver was checking if the interface was DCB capable
> instead of enabled.  This was causing a kernel panic when LLDP
> was enabled/disabled on the link partner switch.
> 
> This patch corrects the situation by having the LLDP event handler
> check the correct flag in the pf structure.  It also cleans up the
> setting and clearing of the enabled flag for other checks.
> 
> Signed-off-by: Dave Ertman <david.m.ertman@...el.com>
> Tested-by: Andrew Bowers <andrewx.bowers@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Applied, thanks Jeff.