lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 2 Sep 2016 19:19:20 +0200
From:   Andrew Lunn <>
To:     Vivien Didelot <>
        "David S. Miller" <>,
        Florian Fainelli <>
Subject: Re: [PATCH net-next 3/3] net: dsa: mv88e6xxx: make global2 code

> I agree. Does the following snippet looks OK?
>             if (mv88e6xxx_has(chip, MV88E6XXX_FLAG_GLOBAL2)) {
>                     dev_err(chip->dev, "Missing support for Global 2 registers\n");

I would include the name of the option which needs enabling. Also it
is not really missing. It has not been enabled.

"The required compile time options needed to support this switch have
not been enabled. Please enable: CONFIG_NET_DSA_MV88E6XXX_GLOBAL2"


Powered by blists - more mailing lists