netdev - Re: [PATCH net-next 3/3] net: dsa: mv88e6xxx: make global2 code optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87vayens26.fsf@ketchup.mtl.sfl>
Date:   Fri, 02 Sep 2016 13:13:21 -0400
From:   Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...oirfairelinux.com,
        "David S. Miller" <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH net-next 3/3] net: dsa: mv88e6xxx: make global2 code optional

Hi Andrew,

Andrew Lunn <andrew@...n.ch> writes:

>> What do you think?
>
> I think the probe() needs to fail with a very obvious error message
> saying you need to recompile your kernel with option XYZ enabled in
> order to support this switch, when the optional stuff is not
> optional...

I agree. Does the following snippet looks OK?


    #ifndef CONFIG_NET_DSA_MV88E6XXX_GLOBAL2
            if (mv88e6xxx_has(chip, MV88E6XXX_FLAG_GLOBAL2)) {
                    dev_err(chip->dev, "Missing support for Global 2 registers\n");
                    return -EOPNOTSUPP;
            }
    #endif /* CONFIG_NET_DSA_MV88E6XXX_GLOBAL2 */


Thanks,

        Vivien