netdev - Re: [PATCH 4/4] net: smsc911x: Move interrupt allocation to open/stop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b8978be5-fd24-6aad-8503-3868337a9934@cogentembedded.com>
Date:   Sat, 3 Sep 2016 23:30:59 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Jeremy Linton <jeremy.linton@....com>, netdev@...r.kernel.org
Cc:     steve.glendinning@...well.net, andrew@...n.ch, will.deacon@....com
Subject: Re: [PATCH 4/4] net: smsc911x: Move interrupt allocation to open/stop

On 09/03/2016 10:23 PM, Sergei Shtylyov wrote:

>> The /proc/irq/xx information is incorrect for smsc911x because
>> the request_irq is happening before the register_netdev has the
>> proper device name. Moving it to the open also fixes the case
>> of when the device is renamed.
>>
>> Reported-by: Will Deacon <will.deacon@....com>
>> Signed-off-by: Jeremy Linton <jeremy.linton@....com>
>> ---
>>  drivers/net/ethernet/smsc/smsc911x.c | 47 ++++++++++++++----------------------
>>  1 file changed, 18 insertions(+), 29 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/smsc/smsc911x.c
>> b/drivers/net/ethernet/smsc/smsc911x.c
>> index c2e56f0..4f8910b 100644
>> --- a/drivers/net/ethernet/smsc/smsc911x.c
>> +++ b/drivers/net/ethernet/smsc/smsc911x.c
> [...]
>> @@ -2480,38 +2491,18 @@ static int smsc911x_drv_probe(struct platform_device
>> *pdev)
>>      if (retval < 0)
>>          goto out_disable_resources;
>>
>> -    /* configure irq polarity and type before connecting isr */
>> -    if (pdata->config.irq_polarity == SMSC911X_IRQ_POLARITY_ACTIVE_HIGH)
>> -        intcfg |= INT_CFG_IRQ_POL_;
>> -
>> -    if (pdata->config.irq_type == SMSC911X_IRQ_TYPE_PUSH_PULL)
>> -        intcfg |= INT_CFG_IRQ_TYPE_;
>> -
>> -    smsc911x_reg_write(pdata, INT_CFG, intcfg);
>> -
>> -    /* Ensure interrupts are globally disabled before connecting ISR */
>> -    smsc911x_disable_irq_chip(dev);
>> -
>
>    Hmm, I didn't see where this code got moved to...

    Ah, it's the duplicated code... you should've either explicitly stated 
that in the change log or done this in a separate patch, I think.

[...]

MBR, Sergei