netdev - Re: [PATCH 2/4] net: smsc911x: Fix register_netdev, phy startup, driver unload ordering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20eb6c56-c89b-db8b-a19b-f51b2745fffc@cogentembedded.com>
Date:   Sun, 4 Sep 2016 00:19:46 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Jeremy Linton <jeremy.linton@....com>, netdev@...r.kernel.org
Cc:     steve.glendinning@...well.net, andrew@...n.ch, will.deacon@....com
Subject: Re: [PATCH 2/4] net: smsc911x: Fix register_netdev, phy startup,
 driver unload ordering

On 09/01/2016 11:15 PM, Jeremy Linton wrote:

> Move phy startup/shutdown into the smsc911x_open/stop routines. This
> allows the module to be unloaded because phy_connect_direct is no longer
> always holding the module use count. This one change also resolves a
> number of other problems.
>
> The link status of a downed interface no longer reflects a stale state.
> Errors caused by the net device being opened before the mdio/phy was
> configured. There is also a potential power savings as the phy's don't
> remain powered when the interface isn't running.
>
> Signed-off-by: Jeremy Linton <jeremy.linton@....com>

    Wow, this patch has fixed DHCP/NFS boot failure on my Renesas V2H boards!
Thanks again for your work! :-)

MBR, Sergei