netdev - Re: [PATCH v3 3/6] bpf: add BPF_PROG_ATTACH and BPF_PROG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4c7dbf97-4241-0ea2-518c-7e26faa0b059@zonque.org>
Date:   Mon, 5 Sep 2016 17:40:09 +0200
From:   Daniel Mack <daniel@...que.org>
To:     David Laight <David.Laight@...LAB.COM>,
        Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc:     "htejun@...com" <htejun@...com>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "ast@...com" <ast@...com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kafai@...com" <kafai@...com>, "fw@...len.de" <fw@...len.de>,
        "pablo@...filter.org" <pablo@...filter.org>,
        "harald@...hat.com" <harald@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "sargun@...gun.me" <sargun@...gun.me>
Subject: Re: [PATCH v3 3/6] bpf: add BPF_PROG_ATTACH and BPF_PROG_DETACH
 commands

On 09/05/2016 05:30 PM, David Laight wrote:
> From: Daniel Mack
>>>> +
>>>> +	struct { /* anonymous struct used by BPF_PROG_ATTACH/DETACH commands */
>>>> +		__u32		target_fd;	/* container object to attach to */
>>>> +		__u32		attach_bpf_fd;	/* eBPF program to attach */
>>>> +		__u32		attach_type;	/* BPF_ATTACH_TYPE_* */
>>>> +		__u64		attach_flags;
>>>> +	};
>>>
>>> there is a 4 byte hole in this struct. Can we pack it differently?
>>
>> Okay - I swapped "type" and "flags" to repair this.
> 
> That just moves the pad to the end of the structure.
> Still likely to cause a problem for 32bit apps on a 64bit kernel.

What kind of problem do you have in mind? Again, this is embedded in a
union of much bigger total size, and the API is not used in any kind of
hot-path.

> If you can't think of any flags, why 64 of them?

I can't think of them right now, but this is about defining an API that
can be used in other context as well. Also, it doesn't matter at all,
they don't harm. IMO, it's just better to have them right away than to
do a binary compat dance once someone needs them.


Thanks,
Daniel