netdev - Re: [PATCH v2] net: Don't delete routes in different VRFs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160906.135641.2126464263336660217.davem@davemloft.net>
Date:   Tue, 06 Sep 2016 13:56:41 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     mark.tomlinson@...iedtelesis.co.nz
Cc:     netdev@...r.kernel.org, dsa@...ulusnetworks.com
Subject: Re: [PATCH v2] net: Don't delete routes in different VRFs

From: Mark Tomlinson <mark.tomlinson@...iedtelesis.co.nz>
Date: Mon,  5 Sep 2016 10:20:20 +1200

> When deleting an IP address from an interface, there is a clean-up of
> routes which refer to this local address. However, there was no check to
> see that the VRF matched. This meant that deletion wasn't confined to
> the VRF it should have been.
> 
> To solve this, a new field has been added to fib_info to hold a table
> id. When removing fib entries corresponding to a local ip address, this
> table id is also used in the comparison.
> 
> The table id is populated when the fib_info is created. This was already
> done in some places, but not in ip_rt_ioctl(). This has now been fixed.
> 
> Fixes: 021dd3b8a142 ("net: Add routes to the table associated with the device")
> Acked-by: David Ahern <dsa@...ulusnetworks.com>
> Tested-by: David Ahern <dsa@...ulusnetworks.com>
> Signed-off-by: Mark Tomlinson <mark.tomlinson@...iedtelesis.co.nz>

Applied and queued up for -stable, thanks.