netdev - Re: [PATCH] tcp: cwnd does not increase in TCP YeAH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160906.135846.2108420188600081714.davem@davemloft.net>
Date:   Tue, 06 Sep 2016 13:58:46 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     agermanov@...horfree.com
Cc:     netdev@...r.kernel.org, nanditad@...gle.com, edumazet@...gle.com,
        ncardwell@...gle.com, ycheng@...gle.com
Subject: Re: [PATCH] tcp: cwnd does not increase in TCP YeAH

From: Artem Germanov <agermanov@...horfree.com>
Date: Sun, 4 Sep 2016 21:03:27 -0700

> Commit 76174004a0f19785a328f40388e87e982bbf69b9
> (tcp: do not slow start when cwnd equals ssthresh )
> introduced regression in TCP YeAH. Using 100ms delay 1% loss virtual
> ethernet link kernel 4.2 shows bandwidth ~500KB/s for single TCP
> connection and kernel 4.3 and above (including 4.8-rc4) shows
> bandwidth ~100KB/s.
>  That is caused by stalled cwnd when cwnd equals ssthresh. This patch
>  fixes it by proper increasing cwnd in this case.
> 
> Signed-off-by: Artem Germanov <agermanov@...horfree.com>

This patch won't apply properly.

First, it isn't rooted properly.

Second, all the TAB characters have been mangled into spaces.

Please fix these problems, send a test patch to yourself, and only
resubmit this patch when you can successfully apply that test patch.

Thank you.