netdev - Re: [PATCH net-next V5 4/4] net/sched: Introduce act_tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6b4fc960-ee0a-c85a-13eb-fe33c36bef4a@mojatatu.com>
Date:   Tue, 6 Sep 2016 08:44:55 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Hadar Hen Zion <hadarh@....mellanox.co.il>
Cc:     Hadar Hen Zion <hadarh@...lanox.com>,
        "David S. Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>, Jiri Pirko <jiri@...lanox.com>,
        Jiri Benc <jbenc@...hat.com>,
        Shmulik Ladkani <shmulik.ladkani@...il.com>,
        Tom Herbert <tom@...bertland.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Amir Vadai <amirva@...lanox.com>,
        Or Gerlitz <ogerlitz@...lanox.com>, Amir Vadai <amir@...ai.me>
Subject: Re: [PATCH net-next V5 4/4] net/sched: Introduce act_tunnel_key

On 16-09-06 07:03 AM, Hadar Hen Zion wrote:
> On Tue, Sep 6, 2016 at 1:49 PM, Jamal Hadi Salim <jhs@...atatu.com> wrote:

>> Please verify by running a test and send a packet or two
>> and verify that stats are incremented (I know it may sound silly to
>> ask but it is important).
>
> Already tested that tc filter stats are working and incremented as expected :-)

I did see issue with per-cpu counters when i updated to rcu.
But the test was on a VM. So i changed skbmod to use global stats.
Maybe the kernel i was testing had issues.
Eric may have some insights.

cheers,
jamal