netdev - Re: [PATCH net-next V5 4/4] net/sched: Introduce act_tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1473171094.10725.1.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Tue, 06 Sep 2016 07:11:34 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Hadar Hen Zion <hadarh@...lanox.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Jiri Pirko <jiri@...lanox.com>, Jiri Benc <jbenc@...hat.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Shmulik Ladkani <shmulik.ladkani@...il.com>,
        Tom Herbert <tom@...bertland.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Amir Vadai <amirva@...lanox.com>,
        Or Gerlitz <ogerlitz@...lanox.com>, Amir Vadai <amir@...ai.me>
Subject: Re: [PATCH net-next V5 4/4] net/sched: Introduce act_tunnel_key

On Sun, 2016-09-04 at 13:55 +0300, Hadar Hen Zion wrote:
> From: Amir Vadai <amir@...ai.me>

...

> +struct tcf_tunnel_key_params {
> +	struct rcu_head		rcu;
> +	int			tcft_action;
> +	int			action;
> +	struct metadata_dst     *tcft_enc_metadata;
> +};
> +
> +struct tcf_tunnel_key {
> +	struct tc_action	      common;
> +	struct tcf_tunnel_key_params *params;

In order to please sparse you must add __rcu qualifier, as in :

struct tcf_tunnel_key_params __rcu *params;

> +};
> +

Thanks.