netdev - Re: [PATCH net-next V2 6/6] net/mlx5: Add handling for port module event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALzJLG9J2h2UCL-Zbq3W7jBnNmG8RkC_U4R-=JTvOkKk3RwqmA@mail.gmail.com>
Date:   Wed, 7 Sep 2016 17:50:36 +0300
From:   Saeed Mahameed <saeedm@....mellanox.co.il>
To:     Joe Perches <joe@...ches.com>
Cc:     Saeed Mahameed <saeedm@...lanox.com>,
        "David S. Miller" <davem@...emloft.net>,
        Linux Netdev List <netdev@...r.kernel.org>,
        Huy Nguyen <huyn@...lanox.com>,
        Or Gerlitz <ogerlitz@...lanox.com>
Subject: Re: [PATCH net-next V2 6/6] net/mlx5: Add handling for port module event

On Tue, Sep 6, 2016 at 7:15 PM, Joe Perches <joe@...ches.com> wrote:
> On Tue, 2016-09-06 at 19:04 +0300, Saeed Mahameed wrote:
>> From: Huy Nguyen <huyn@...lanox.com>
>
> []
>
>> +void mlx5_port_module_event(struct mlx5_core_dev *dev, struct mlx5_eqe *eqe)
>> +{
>> > +   struct mlx5_eqe_port_module *module_event_eqe;
>> > +   u8 module_status;
>> > +   u8 module_num;
>> > +   u8 error_type;
>> +
>> > +   module_event_eqe = &eqe->data.port_module;
>> > +   module_num = module_event_eqe->module;
>> > +   module_status = module_event_eqe->module_status &
>> > +                   PORT_MODULE_EVENT_MODULE_STATUS_MASK;
>> > +   error_type = module_event_eqe->error_type &
>> > +                PORT_MODULE_EVENT_ERROR_TYPE_MASK;
>> +
>> > +   switch (module_status) {
>> > +   case MLX5_MODULE_STATUS_PLUGGED:
>> +             mlx5_core_info(dev, "Module %u, status: plugged", module_num);
>
>
> Missing format '\n' line terminations

Right, will fix this.

Thanks

>
>> +             break;
>> +
>> > +   case MLX5_MODULE_STATUS_UNPLUGGED:
>> > +           mlx5_core_info(dev, "Module %u, status: unplugged", module_num);
>> > +           break;
>> +
>> > +   case MLX5_MODULE_STATUS_ERROR:
>> > +           mlx5_core_info(dev, "Module %u, status: error, %s", module_num,
>> > +                          mlx5_port_event_error_type_to_string(error_type));
>> > +           break;
>> +
>> > +   default:
>> > +           mlx5_core_info(dev, "Module %u, unknown module status %x",
>> > +                          module_num, module_status);
>> +     }
>
> Should any of these be ratelimited?
>

Huy is checking with the HW/FW guys.  they shouldn't flood the driver
by design, but to be
in the safe side, we will double check.

Thanks,
Saeed.