netdev - Re: [PATCH net-next 1/2] tcp: measure rwnd-limited time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1473257956.10725.26.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Wed, 07 Sep 2016 07:19:16 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     "Francis Y. Yan" <francisyyan@...il.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        soheil@...gle.com, ncardwell@...gle.com,
        Yuchung Cheng <ycheng@...gle.com>
Subject: Re: [PATCH net-next 1/2] tcp: measure rwnd-limited time

On Tue, 2016-09-06 at 18:32 -0700, Francis Y. Yan wrote:
> This patch measures the total time when TCP transmission is limited
> by receiver's advertised window (rwnd), and exports it in tcp_info as
> tcpi_rwnd_limited.
> 
> The rwnd-limited time is defined as the period when the next segment
> to send by TCP cannot fit into rwnd. To measure it, we record the last
> timestamp when limited by rwnd (rwnd_limited_ts) and the total
> rwnd-limited time (rwnd_limited) in tcp_sock.
> 
> Then we export the total rwnd-limited time so far in tcp_info, where
> by so far, we mean that if TCP transmission is still being limited by
> rwnd, the time interval since rwnd_limited_ts needs to be counted as
> well; otherwise, we simply export rwnd_limited.
> 
> It is worth noting that we also have to add a new sequence counter
> (seqcnt) in tcp_sock to carefully handle tcp_info's reading of
> rwnd_limited_ts and rwnd_limited in order to get a consistent snapshot
> of both variables together.
> 
> Signed-off-by: Francis Y. Yan <francisyyan@...il.com>
> Signed-off-by: Yuchung Cheng <ycheng@...gle.com>
> ---

Acked-by: Eric Dumazet <edumazet@...gle.com>

Thanks Francis !