netdev - Re: [PATCH net] tcp: fastopen: avoid negative sk_forward

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160908.160831.1125164231859991114.davem@davemloft.net>
Date:   Thu, 08 Sep 2016 16:08:31 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org, johunt@...mai.com, hkchu@...gle.com,
        ycheng@...gle.com, ncardwell@...gle.com
Subject: Re: [PATCH net] tcp: fastopen: avoid negative sk_forward_alloc

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 07 Sep 2016 08:34:11 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> When DATA and/or FIN are carried in a SYN/ACK message or SYN message,
> we append an skb in socket receive queue, but we forget to call
> sk_forced_mem_schedule().
> 
> Effect is that the socket has a negative sk->sk_forward_alloc as long as
> the message is not read by the application.
> 
> Josh Hunt fixed a similar issue in commit d22e15371811 ("tcp: fix tcp
> fin memory accounting")
>  
> Fixes: 168a8f58059a ("tcp: TCP Fast Open Server - main code path")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied and queued up for -stable.