netdev - Re: [PATCH net-next v3] net: inet: diag: expose the socket mark to privileged processes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160908.161348.297729487225819070.davem@davemloft.net>
Date:   Thu, 08 Sep 2016 16:13:48 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     lorenzo@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        dsa@...ulusnetworks.com, ek@...gle.com
Subject: Re: [PATCH net-next v3] net: inet: diag: expose the socket mark to
 privileged processes.

From: Lorenzo Colitti <lorenzo@...gle.com>
Date: Thu,  8 Sep 2016 00:42:25 +0900

> This adds the capability for a process that has CAP_NET_ADMIN on
> a socket to see the socket mark in socket dumps.
> 
> Commit a52e95abf772 ("net: diag: allow socket bytecode filters to
> match socket marks") recently gave privileged processes the
> ability to filter socket dumps based on mark. This patch is
> complementary: it ensures that the mark is also passed to
> userspace in the socket's netlink attributes.  It is useful for
> tools like ss which display information about sockets.
> 
> Tested: https://android-review.googlesource.com/270210
> Signed-off-by: Lorenzo Colitti <lorenzo@...gle.com>

Applied, but the argument list of inet_sk_diag_fill is starting to get out
of control.