netdev - Re: [PATCH net-next] net/sched: act_tunnel_key: Remove rcu_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1473689857.18970.71.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Mon, 12 Sep 2016 07:17:37 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     John Fastabend <john.fastabend@...il.com>
Cc:     Hadar Hen Zion <hadarh@...lanox.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Jiri Pirko <jiri@...lanox.com>, Jiri Benc <jbenc@...hat.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Shmulik Ladkani <shmulik.ladkani@...il.com>,
        Tom Herbert <tom@...bertland.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Amir Vadai <amirva@...lanox.com>,
        Or Gerlitz <ogerlitz@...lanox.com>
Subject: Re: [PATCH net-next] net/sched: act_tunnel_key: Remove
 rcu_read_lock protection

On Mon, 2016-09-12 at 07:09 -0700, John Fastabend wrote:
> On 16-09-12 05:19 AM, Hadar Hen Zion wrote:
> > Remove rcu_read_lock protection from tunnel_key_dump and use
> > rtnl_dereference, dump operation is protected by  rtnl lock.
> > 
> > Also, remove rcu_read_lock from tunnel_key_release and use
> > rcu_dereference_protected.
> > 
> > Both operations are running exclusively and a writer couldn't modify
> > t->params while those functions are executed.
> > 
> > Fixes: 54d94fd89d90 ('net/sched: Introduce act_tunnel_key')
> > Signed-off-by: Hadar Hen Zion <hadarh@...lanox.com>
> > ---
> 
> Thanks for cleaning this up.
> 
> Acked-by: John Fastabend <john.r.fastabend@...el.com>

Exactly, we now have a nice canonical net/sched/act_... component.

Acked-by: Eric Dumazet <edumazet@...gle.com>

Thanks guys.