netdev - Re: [PATCH net-next] net/sched: act_tunnel_key: Remove rcu_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160915.191832.731244761336539212.davem@davemloft.net>
Date:   Thu, 15 Sep 2016 19:18:32 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     hadarh@...lanox.com
Cc:     netdev@...r.kernel.org, jiri@...lanox.com, jbenc@...hat.com,
        jhs@...atatu.com, shmulik.ladkani@...il.com, tom@...bertland.com,
        edumazet@...gle.com, xiyou.wangcong@...il.com, amirva@...lanox.com,
        ogerlitz@...lanox.com
Subject: Re: [PATCH net-next] net/sched: act_tunnel_key: Remove
 rcu_read_lock protection

From: Hadar Hen Zion <hadarh@...lanox.com>
Date: Mon, 12 Sep 2016 15:19:21 +0300

> Remove rcu_read_lock protection from tunnel_key_dump and use
> rtnl_dereference, dump operation is protected by  rtnl lock.
> 
> Also, remove rcu_read_lock from tunnel_key_release and use
> rcu_dereference_protected.
> 
> Both operations are running exclusively and a writer couldn't modify
> t->params while those functions are executed.
> 
> Fixes: 54d94fd89d90 ('net/sched: Introduce act_tunnel_key')
> Signed-off-by: Hadar Hen Zion <hadarh@...lanox.com>

Applied.