netdev - Re: [PATCH v2] xen-netback: fix error handling on netback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160917.095631.1210055450319054136.davem@davemloft.net>
Date:   Sat, 17 Sep 2016 09:56:31 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     filipe.manco@...lab.eu
Cc:     netdev@...r.kernel.org, wei.liu2@...rix.com,
        xen-devel@...ts.xenproject.org
Subject: Re: [PATCH v2] xen-netback: fix error handling on netback_probe()

From: Filipe Manco <filipe.manco@...lab.eu>
Date: Thu, 15 Sep 2016 17:10:46 +0200

> In case of error during netback_probe() (e.g. an entry missing on the
> xenstore) netback_remove() is called on the new device, which will set
> the device backend state to XenbusStateClosed by calling
> set_backend_state(). However, the backend state wasn't initialized by
> netback_probe() at this point, which will cause and invalid transaction
> and set_backend_state() to BUG().
> 
> Initialize the backend state at the beginning of netback_probe() to
> XenbusStateInitialising, and create two new valid state transitions on
> set_backend_state(), from XenbusStateInitialising to XenbusStateClosed,
> and from XenbusStateInitialising to XenbusStateInitWait.
> 
> Signed-off-by: Filipe Manco <filipe.manco@...lab.eu>

Applied, thanks.