netdev - Re: [PATCH v2] xen-netback: fix error handling on netback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160916113018.GC21888@citrix.com>
Date:   Fri, 16 Sep 2016 12:30:18 +0100
From:   Wei Liu <wei.liu2@...rix.com>
To:     Filipe Manco <filipe.manco@...lab.eu>
CC:     <netdev@...r.kernel.org>, <wei.liu2@...rix.com>,
        <xen-devel@...ts.xenproject.org>
Subject: Re: [PATCH v2] xen-netback: fix error handling on netback_probe()

On Thu, Sep 15, 2016 at 05:10:46PM +0200, Filipe Manco wrote:
> In case of error during netback_probe() (e.g. an entry missing on the
> xenstore) netback_remove() is called on the new device, which will set
> the device backend state to XenbusStateClosed by calling
> set_backend_state(). However, the backend state wasn't initialized by
> netback_probe() at this point, which will cause and invalid transaction
> and set_backend_state() to BUG().
> 
> Initialize the backend state at the beginning of netback_probe() to
> XenbusStateInitialising, and create two new valid state transitions on
> set_backend_state(), from XenbusStateInitialising to XenbusStateClosed,
> and from XenbusStateInitialising to XenbusStateInitWait.
> 
> Signed-off-by: Filipe Manco <filipe.manco@...lab.eu>

Acked-by: Wei Liu <wei.liu2@...rix.com>