netdev - Re: [PATCH] net: ipv6: fallback to full lookup if table lookup is unsuitable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m3a8f3k53f.fsf@neo.luffy.cx>
Date:   Mon, 19 Sep 2016 22:27:32 +0200
From:   Vincent Bernat <vincent@...nat.im>
To:     David Miller <davem@...emloft.net>
Cc:     dsa@...ulusnetworks.com, kuznet@....inr.ac.ru, jmorris@...ei.org,
        yoshfuji@...ux-ipv6.org, kaber@...sh.net, netdev@...r.kernel.org
Subject: Re: [PATCH] net: ipv6: fallback to full lookup if table lookup is unsuitable

 ❦ 19 septembre 2016 06:58 CEST, David Miller <davem@...emloft.net> :

>> @@ -1808,6 +1808,30 @@ static struct rt6_info *ip6_nh_lookup_table(struct net *net,
>>  	return rt;
>>  }
>>  
>> +static int ip6_nh_valid(struct rt6_info *grt,
>> +			struct net_device **dev, struct inet6_dev **idev) {
>> +	int ret = 0;
>
> First, this is not formatted properly.  The openning brace should start
> on a new line.
>
> Second, please use "bool", "true", and "false" for the return value.

Noted for the next time. However, the v3 version of the patch doesn't
have the function anymore.
-- 
Avoid temporary variables.
            - The Elements of Programming Style (Kernighan & Plauger)