netdev - Re: [PATCH] net: ipv6: fallback to full lookup if table lookup is unsuitable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160919.005857.553516799273302087.davem@davemloft.net>
Date:   Mon, 19 Sep 2016 00:58:57 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     vincent@...nat.im
Cc:     dsa@...ulusnetworks.com, kuznet@....inr.ac.ru, jmorris@...ei.org,
        yoshfuji@...ux-ipv6.org, kaber@...sh.net, netdev@...r.kernel.org
Subject: Re: [PATCH] net: ipv6: fallback to full lookup if table lookup is
 unsuitable

From: Vincent Bernat <vincent@...nat.im>
Date: Fri, 16 Sep 2016 14:55:31 +0200

> @@ -1808,6 +1808,30 @@ static struct rt6_info *ip6_nh_lookup_table(struct net *net,
>  	return rt;
>  }
>  
> +static int ip6_nh_valid(struct rt6_info *grt,
> +			struct net_device **dev, struct inet6_dev **idev) {
> +	int ret = 0;

First, this is not formatted properly.  The openning brace should start
on a new line.

Second, please use "bool", "true", and "false" for the return value.

Thanks.