netdev - Re: [RFC v2 00/11] QLogic RDMA Driver (qedr) RFC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 20 Sep 2016 15:11:51 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Ram Amrani <Ram.Amrani@...ium.com>
Cc:     davem@...emloft.net, dledford@...hat.com, Ariel.Elior@...ium.com,
        Michal.Kalderon@...ium.com, Yuval.Mintz@...ium.com,
        rajesh.borundia@...ium.com, linux-rdma@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [RFC v2 00/11] QLogic RDMA Driver (qedr) RFC

On Tue, Sep 20, 2016 at 01:35:52PM +0300, Ram Amrani wrote:
> From: Ram amrani <Ram.Amrani@...ium.com>
>
> This series introduces RoCE RDMA driver for the 579xx RDMA products by Qlogic.
> The RDMA support is added as an additional loadable module (qedr) over the
> Ethernet qede driver.
> The qedr module will support both RoCE and iWarp, although this series only
> adds RoCE support.
> The qed and qede drivers are enhanced with functionality required for RDMA
> support.
>
> Based on net-next 4c73195edbe3a5d7e14ea549bb261cf35c29f0cc.
>
> The series adds on top of RFC v1:
> * a check for all drivers that IB_ACCESS_MW_BIND isn't set for ib_get_dma_mr
> * relocation of qedr user API to include/rdma/uapi/providers/
> * removal of qedr_devlist_local
> * fixed error handling in qedr_alloc_resources()
> * configuration of PBL in ib_map_mr_sg() driver implementation,
>   rather than post_send's IB_WR_REG_MR
> * misc.: placed code in proper patch, fixed a few comments,
>   removed extra parentheses
>
> Thanks for everyone which pointed out problems in the driver.
>
> Any review/comment is appreciated.

Very nice,
Any reason why didn't you drop debug module parameter and decided to
mimic already available kernel core functionality?

You got technical explanations why it is bad idea to use it. If you need additional voices
to support my claims, you will find them in thread about VERBOSE flag and responses from
Doug, and Dennis.

Thanks

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)