netdev - Re: [RFC v2 04/12] qedr: Add support for user context verbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 20 Sep 2016 09:27:29 -0600
From:   Jason Gunthorpe <jgunthorpe@...idianresearch.com>
To:     Ram Amrani <Ram.Amrani@...ium.com>
Cc:     davem@...emloft.net, dledford@...hat.com, Ariel.Elior@...ium.com,
        Michal.Kalderon@...ium.com, Yuval.Mintz@...ium.com,
        rajesh.borundia@...ium.com, linux-rdma@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [RFC v2 04/12] qedr: Add support for user context verbs

On Tue, Sep 20, 2016 at 01:35:56PM +0300, Ram Amrani wrote:
> +++ b/include/uapi/rdma/providers/qedr-abi.h
> @@ -0,0 +1,27 @@
> +/* QLogic qed NIC Driver
> + * Copyright (c) 2015 QLogic Corporation
> + *
> + * This software is available under the terms of the GNU General Public License
> + * (GPL) Version 2, available from the file COPYING in the main directory of
> + * this source tree.
> + */
> +#ifndef __QEDR_USER_H__
> +#define __QEDR_USER_H__
> +
> +#define QEDR_ABI_VERSION		(6)
> +
> +/* user kernel communication data structures. */
> +
> +struct qedr_alloc_ucontext_resp {
> +	u64 db_pa;
> +	u32 db_size;
> +
> +	u32 max_send_wr;
> +	u32 max_recv_wr;
> +	u32 max_srq_wr;
> +	u32 sges_per_send_wr;
> +	u32 sges_per_recv_wr;
> +	u32 sges_per_srq_wr;

uapi headers need the __ varients and the #include <linux/types.h>

Follow what Leon has done.

> +	int max_cqes;

Do not use int here.

Is there really only 1 struct? Your driver never uses udata for
anything else?

Jason