netdev - Re: [RFC v2 06/12] qedr: Add support for QP verbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160920152849.GD32020@obsidianresearch.com>
Date:   Tue, 20 Sep 2016 09:28:49 -0600
From:   Jason Gunthorpe <jgunthorpe@...idianresearch.com>
To:     Ram Amrani <Ram.Amrani@...ium.com>
Cc:     davem@...emloft.net, dledford@...hat.com, Ariel.Elior@...ium.com,
        Michal.Kalderon@...ium.com, Yuval.Mintz@...ium.com,
        rajesh.borundia@...ium.com, linux-rdma@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [RFC v2 06/12] qedr: Add support for QP verbs

On Tue, Sep 20, 2016 at 01:35:58PM +0300, Ram Amrani wrote:
> +++ b/include/uapi/rdma/providers/qedr-abi.h
> @@ -43,4 +43,39 @@ struct qedr_create_cq_uresp {
>         u16 icid;
>  };

Ugh, each patch keeps adding to this?

> +struct qedr_create_qp_ureq {
> +       u32 qp_handle_hi;
> +       u32 qp_handle_lo;
> +
> +       /* SQ */
> +       /* user space virtual address of SQ buffer */
> +       u64 sq_addr;
> +
> +       /* length of SQ buffer */
> +       size_t sq_len;

Do not use size_t, that is just asking for 32/64 bit interop problems.

> +struct qedr_create_qp_uresp {
> +       u32 qp_id;
> +       int atomic_supported;

int again, etc. You get the idea.

Jason