netdev - Re: [PATCH v4 net-next 01/16] tcp: cdg: rename struct minmax in tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA++eYdvqpUkJWi6O_Kr4YG+WPMPJYUzBOyFKogRQSKQ5UpOMWw@mail.gmail.com>
Date:   Tue, 20 Sep 2016 18:40:01 +0200
From:   Kenneth Klette Jonassen <kennetkl@....uio.no>
To:     Neal Cardwell <ncardwell@...gle.com>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Soheil Hassas Yeganeh <soheil@...gle.com>,
        Yuchung Cheng <ycheng@...gle.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Kenneth Klette Jonassen <kennetkl@....uio.no>
Subject: Re: [PATCH v4 net-next 01/16] tcp: cdg: rename struct minmax in
 tcp_cdg.c to avoid a naming conflict

On Tue, Sep 20, 2016 at 5:39 AM, Neal Cardwell <ncardwell@...gle.com> wrote:
>
> From: Soheil Hassas Yeganeh <soheil@...gle.com>
>
> The upcoming change "lib/win_minmax: windowed min or max estimator"
> introduces a struct called minmax, which is then included in
> include/linux/tcp.h in the upcoming change "tcp: use windowed min
> filter library for TCP min_rtt estimation". This would create a
> compilation error for tcp_cdg.c, which defines its own minmax
> struct. To avoid this naming conflict (and potentially others in the
> future), this commit renames the version used in tcp_cdg.c to
> cdg_minmax.
>
> Signed-off-by: Soheil Hassas Yeganeh <soheil@...gle.com>
> Signed-off-by: Neal Cardwell <ncardwell@...gle.com>
> Signed-off-by: Yuchung Cheng <ycheng@...gle.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Kenneth Klette Jonassen <kennetkl@....uio.no>

Acked-by: Kenneth Klette Jonassen <kennetkl@....uio.no>