netdev - Re: [PATCH 3/6] ip xfrm state: add save/restore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160920094331.4a3c08de@xeon-e3>
Date:   Tue, 20 Sep 2016 09:43:31 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Pavel Tikhomirov <ptikhomirov@...tuozzo.com>
Cc:     netdev@...r.kernel.org,
        Konstantin Khorenko <khorenko@...tuozzo.com>,
        crml <criu@...nvz.org>
Subject: Re: [PATCH 3/6] ip xfrm state: add save/restore

On Fri,  2 Sep 2016 12:02:23 +0300
Pavel Tikhomirov <ptikhomirov@...tuozzo.com> wrote:

> +static __u32 state_dump_magic = 0x71706987;
> +
> +static int xfrm_state_list_deleteall_or_save(int argc, char **argv, int deleteall, int save)

I have no problem with the overall functionality of this patch set, but this
function_name_is_too_long_for_rational_humans.

Please make the function names (especially the local static ones) shorter and more reasonable
and resubmit