netdev - Re: [PATCH v4 net-next 16/16] tcp_bbr: add BBR congestion control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADVnQynTjLK6r2NyRiZzGbem-v_OPL9zih6Oz9V_cBEiVdW-1g@mail.gmail.com>
Date:   Tue, 20 Sep 2016 22:57:42 -0400
From:   Neal Cardwell <ncardwell@...gle.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     David Miller <davem@...emloft.net>,
        Netdev <netdev@...r.kernel.org>, Van Jacobson <vanj@...gle.com>,
        Yuchung Cheng <ycheng@...gle.com>,
        Nandita Dukkipati <nanditad@...gle.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Soheil Hassas Yeganeh <soheil@...gle.com>
Subject: Re: [PATCH v4 net-next 16/16] tcp_bbr: add BBR congestion control

On Tue, Sep 20, 2016 at 2:50 PM, Neal Cardwell <ncardwell@...gle.com> wrote:
> On Tue, Sep 20, 2016 at 2:48 PM, Stephen Hemminger
> <stephen@...workplumber.org> wrote:
>>
>> On Mon, 19 Sep 2016 23:39:23 -0400
>> Neal Cardwell <ncardwell@...gle.com> wrote:
>>
>> > +/* INET_DIAG_BBRINFO */
>> > +
>> > +struct tcp_bbr_info {
>> > +     /* u64 bw: max-filtered BW (app throughput) estimate in Byte per sec: */
>> > +     __u32   bbr_bw_lo;              /* lower 32 bits of bw */
>> > +     __u32   bbr_bw_hi;              /* upper 32 bits of bw */
>> > +     __u32   bbr_min_rtt;            /* min-filtered RTT in uSec */
>> > +     __u32   bbr_pacing_gain;        /* pacing gain shifted left 8 bits */
>> > +     __u32   bbr_cwnd_gain;          /* cwnd gain shifted left 8 bits */
>> > +};
>> > +
>>
>> I assume there is a change to iproute (ss) to dump this info?
>
> Yes, we have a patch for iproute2 (inet_diag.h and ss.c), which we've
> been using. We'll send that out ASAP.

Here are the patches with proposed iproute2 support to dump this info:

http://patchwork.ozlabs.org/patch/672538/
http://patchwork.ozlabs.org/patch/672539/
http://patchwork.ozlabs.org/patch/672540/

thanks,
neal