netdev - Re: [PATCH -next] net: qcom/emac: fix return value check in emac_sgmii

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57F2B457.70900@codeaurora.org>
Date:   Mon, 3 Oct 2016 14:41:11 -0500
From:   Timur Tabi <timur@...eaurora.org>
To:     Wei Yongjun <weiyj.lk@...il.com>
Cc:     Wei Yongjun <weiyongjun1@...wei.com>, netdev@...r.kernel.org
Subject: Re: [PATCH -next] net: qcom/emac: fix return value check in
 emac_sgmii_config()

Wei Yongjun wrote:
> From: Wei Yongjun<weiyongjun1@...wei.com>
>
> In case of error, the function ioremap() returns NULL pointer
> not ERR_PTR(). The IS_ERR() test in the return value check
> should be replaced with NULL test.
>
> Also add check for return value of platform_get_resource().
>
> Fixes: 54e19bc74f33 ("net: qcom/emac: do not use devm on internal
> phy pdev")
> Signed-off-by: Wei Yongjun<weiyongjun1@...wei.com>

Acked-by: Timur Tabi <timur@...eaurora.org>

Thanks for this.  When I switched from devm_ioremap_resource() to 
ioremap(), I didn't think to verify the return values.

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.