netdev - Re: [PATCH -next] net: qcom/emac: fix return value check in emac_sgmii

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161003.215338.665781390718403445.davem@davemloft.net>
Date:   Mon, 03 Oct 2016 21:53:38 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     weiyj.lk@...il.com
Cc:     timur@...eaurora.org, weiyongjun1@...wei.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH -next] net: qcom/emac: fix return value check in
 emac_sgmii_config()

From: Wei Yongjun <weiyj.lk@...il.com>
Date: Sat,  1 Oct 2016 09:12:29 +0000

> From: Wei Yongjun <weiyongjun1@...wei.com>
> 
> In case of error, the function ioremap() returns NULL pointer
> not ERR_PTR(). The IS_ERR() test in the return value check
> should be replaced with NULL test.
> 
> Also add check for return value of platform_get_resource().
> 
> Fixes: 54e19bc74f33 ("net: qcom/emac: do not use devm on internal
> phy pdev")
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>

Applied, thanks.