netdev - Re: [PATCH] net: hns: qdd missing \n to end of dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e2df7519-2663-d332-7c3a-90b0243561d6@cogentembedded.com>
Date:   Tue, 4 Oct 2016 15:31:54 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Colin King <colin.king@...onical.com>,
        Salil Mehta <salil.mehta@...wei.com>,
        "David S . Miller" <davem@...emloft.net>,
        Kejian Yan <yankejian@...wei.com>,
        Daode Huang <huangdaode@...ilicon.com>,
        lipeng <lipeng321@...wei.com>, Lisheng <lisheng011@...wei.com>,
        netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: hns: qdd missing \n to end of dev_err messages

Hello.

On 10/04/2016 02:06 PM, Colin King wrote:

> From: Colin Ian King <colin.king@...onical.com>
>
> Trival fix, dev_err messages are missing a \n, so add it.
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
> index a834774..7aeed08 100644
> --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
> +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
> @@ -547,7 +547,7 @@ int hns_mac_set_autoneg(struct hns_mac_cb *mac_cb, u8 enable)
>  	struct mac_driver *mac_ctrl_drv = hns_mac_get_drv(mac_cb);
>
>  	if (mac_cb->phy_if == PHY_INTERFACE_MODE_XGMII && enable) {
> -		dev_err(mac_cb->dev, "enable autoneg is not allowed!");
> +		dev_err(mac_cb->dev, "enable autoneg is not allowed!\n");

    Enabling, perhaps?

>  		return -ENOTSUPP;
>  	}
>
> @@ -571,7 +571,7 @@ int hns_mac_set_pauseparam(struct hns_mac_cb *mac_cb, u32 rx_en, u32 tx_en)
>
>  	if (mac_cb->mac_type == HNAE_PORT_DEBUG) {
>  		if (is_ver1 && (tx_en || rx_en)) {
> -			dev_err(mac_cb->dev, "macv1 cann't enable tx/rx_pause!");
> +			dev_err(mac_cb->dev, "macv1 cann't enable tx/rx_pause!\n");

    Perhaps a good time to fix this "cann't"?

[...]

MBR, Sergei