netdev - Re: [v2] mwifiex: report wakeup for wowlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87vax8p9is.fsf@kamboji.qca.qualcomm.com>
Date:   Tue, 04 Oct 2016 15:46:03 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Rajat Jain <rajatja@...gle.com>
Cc:     Amitkumar Karwar <akarwar@...vell.com>,
        Nishant Sarmukadam <nishants@...vell.com>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        Wei-Ning Huang <wnhuang@...gle.com>,
        Brian Norris <briannorris@...gle.com>,
        Eric Caruso <ejcaruso@...omium.org>,
        Rajat Jain <rajatxjain@...il.com>
Subject: Re: [v2] mwifiex: report wakeup for wowlan

Rajat Jain <rajatja@...gle.com> writes:

> Hello Kalie,
>
> On Mon, Oct 3, 2016 at 6:04 AM, Kalle Valo <kvalo@...eaurora.org> wrote:
>> Rajat Jain <rajatja@...gle.com> wrote:
>>> Enable notifying wakeup source to the PM core in case of
>>> a wake on wireless LAN event.
>>>
>>> Signed-off-by: Wei-Ning Huang <wnhuang@...gle.com>
>>> Signed-off-by: Rajat Jain <rajatja@...gle.com>
>>> Tested-by: Wei-Ning Huang <wnhuang@...omium.org>
>>> Reviewed-by: Eric Caruso <ejcaruso@...omium.org>
>>> Acked-by: Amitkumar Karwar <akarwar@...vell.com>
>>
>> The commit log doesn't give any background info. Does this fix a bug or
>> why is it needed?
>
> Some of chromeos' features (called "darkresume" in chromeos
> terminology) use and track the wake up sources using the wakeup
> attributes in sysfs. Since the wireless device can wake up the host,
> hence we wanted to add it as a wakeup source to the system, and in the
> case of an actual wakeup event, trigger to the PM core that it was
> indeed caused by the device and it increments the different counters
> etc. In the absence of this patch,  the feature wasn't working very
> well (as it was apparently confused about the cause of wake up).

Thanks, makes sense. Please add that to the commit and send v3.

-- 
Kalle Valo