lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <d6dc7a72-aa65-e7fb-8ee6-631124233f10@mojatatu.com> Date: Wed, 12 Oct 2016 07:29:06 -0400 From: Jamal Hadi Salim <jhs@...atatu.com> To: Cong Wang <xiyou.wangcong@...il.com>, netdev@...r.kernel.org Cc: kjlx@...pleofstupid.com Subject: Re: [Patch net] net_sched: reorder pernet ops and act ops registrations On 16-10-11 01:56 PM, Cong Wang wrote: > Krister reported a kernel NULL pointer dereference after > tcf_action_init_1() invokes a_o->init(), it is a race condition > where one thread calling tcf_register_action() to initialize > the netns data after putting act ops in the global list and > the other thread searching the list and then calling > a_o->init(net, ...). > > Fix this by moving the pernet ops registration before making > the action ops visible. This is fine because: a) we don't > rely on act_base in pernet ops->init(), b) in the worst case we > have a fully initialized netns but ops is still not ready so > new actions still can't be created. > > Reported-by: Krister Johansen <kjlx@...pleofstupid.com> > Tested-by: Krister Johansen <kjlx@...pleofstupid.com> > Cc: Jamal Hadi Salim <jhs@...atatu.com> > Signed-off-by: Cong Wang <xiyou.wangcong@...il.com> Acked-by: Jamal Hadi Salim <jhs@...atatu.com> cheers, jamal
Powered by blists - more mailing lists