netdev - Re: [PATCH v6] net: ip, diag -- Add diag interface for raw sockets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161013155837.GD1847@uranus.lan>
Date:   Thu, 13 Oct 2016 18:58:37 +0300
From:   Cyrill Gorcunov <gorcunov@...il.com>
To:     David Ahern <dsa@...ulusnetworks.com>
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        eric.dumazet@...il.com, jhs@...atatu.com,
        linux-kernel@...r.kernel.org, kuznet@....inr.ac.ru,
        jmorris@...ei.org, yoshfuji@...ux-ipv6.org, kaber@...sh.net,
        avagin@...nvz.org, stephen@...workplumber.org
Subject: Re: [PATCH v6] net: ip, diag -- Add diag interface for raw sockets

On Thu, Oct 13, 2016 at 09:43:57AM -0600, David Ahern wrote:
> On 10/13/16 1:16 AM, Cyrill Gorcunov wrote:
> > On Wed, Oct 12, 2016 at 07:55:04PM -0400, David Miller wrote:
> >> From: Cyrill Gorcunov <gorcunov@...il.com>
> >> Date: Wed, 12 Oct 2016 09:53:29 +0300
> >>
> >>> I can't rename the field, neither a can use union.
> >>
> >> Remind me again what is wrong with using an anonymous union?
> > 
> > Anon union would be a preferred but Eric pointed me that even
> > though it might cause problems (https://patchwork.kernel.org/patch/9353365/)
> > 
> >  | Note that some programs could fail to compile with the added union
> >  | anyway.
> >  |
> >  | Some gcc versions are unable to compile a static init with an union
> >  |
> >  | struct inet_diag_req_v2 foo = { .pad = 0, sdiag_family = AF_INET, };
> >  |
> >  | When I cooked my recent fq commit I simply removed a pad and replaced
> >  | it :
> >  |
> >  | git show fefa569a9d4bc4 -- include
> > 
> 
> That commit suggests it is acceptable to just rename the
> pad field, which is the simplest approach.

No. In further message Eric points that

| This is a bit different of course, since struct tc_fq_qd_stats is only
| one way : Kernel produces the content and gives it to user space.

and we are simply lucky that we didn't break anything in userspace yet.
IOW, it's not a problem for me simply to

 - rename it or,
 - use anonymous union

but both options have own problems :/

Also I just thought what if we introduce

struct inet_diag_req_raw_v2 {
	__u8	sdiag_family;
	__u8	sdiag_protocol;
	__u8	idiag_ext;
	__u8	sdiag_raw_protocol;
	__u32	idiag_states;
	struct inet_diag_sockid id;
};

where @sdiag_raw_protocol explicitly stated and
will collide with existing struct inet_diag_req_v2?
This is a hack too of course but at least this
won't break api definitely.