netdev - Re: [PATCH v6] net: ip, diag -- Add diag interface for raw sockets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e59c339f-ca3d-92e9-88e0-8c3e9e02e01a@cumulusnetworks.com>
Date:   Thu, 13 Oct 2016 09:43:57 -0600
From:   David Ahern <dsa@...ulusnetworks.com>
To:     Cyrill Gorcunov <gorcunov@...il.com>,
        David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com, jhs@...atatu.com,
        linux-kernel@...r.kernel.org, kuznet@....inr.ac.ru,
        jmorris@...ei.org, yoshfuji@...ux-ipv6.org, kaber@...sh.net,
        avagin@...nvz.org, stephen@...workplumber.org
Subject: Re: [PATCH v6] net: ip, diag -- Add diag interface for raw sockets

On 10/13/16 1:16 AM, Cyrill Gorcunov wrote:
> On Wed, Oct 12, 2016 at 07:55:04PM -0400, David Miller wrote:
>> From: Cyrill Gorcunov <gorcunov@...il.com>
>> Date: Wed, 12 Oct 2016 09:53:29 +0300
>>
>>> I can't rename the field, neither a can use union.
>>
>> Remind me again what is wrong with using an anonymous union?
> 
> Anon union would be a preferred but Eric pointed me that even
> though it might cause problems (https://patchwork.kernel.org/patch/9353365/)
> 
>  | Note that some programs could fail to compile with the added union
>  | anyway.
>  |
>  | Some gcc versions are unable to compile a static init with an union
>  |
>  | struct inet_diag_req_v2 foo = { .pad = 0, sdiag_family = AF_INET, };
>  |
>  | When I cooked my recent fq commit I simply removed a pad and replaced
>  | it :
>  |
>  | git show fefa569a9d4bc4 -- include
> 

That commit suggests it is acceptable to just rename the pad field, which is the simplest approach.