netdev - Re: [PATCH net] net_sched: do not broadcast RTM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20161013.095403.1806984759673575482.davem@davemloft.net>
Date:   Thu, 13 Oct 2016 09:54:03 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org, jhs@...atatu.com
Subject: Re: [PATCH net] net_sched: do not broadcast RTM_GETTFILTER result

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Sun, 09 Oct 2016 20:25:55 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> There are two ways to get tc filters from kernel to user space.
> 
> 1) Full dump (tc_dump_tfilter())
> 2) RTM_GETTFILTER to get one precise filter, reducing overhead.
> 
> The second operation is unfortunately broadcasting its result,
> polluting "tc monitor" users.
> 
> This patch makes sure only the requester gets the result, using
> netlink_unicast() instead of rtnetlink_send()
> 
> Jamal cooked an iproute2 patch to implement "tc filter get" operation,
> but other user space libraries already use RTM_GETTFILTER when a single
> filter is queried, instead of dumping all filters.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks Eric.

Want me to queue this up for -stable too?