netdev - Re: [PATCH] qed: fix old-style function definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20161013.095532.1238800778112994579.davem@davemloft.net>
Date:   Thu, 13 Oct 2016 09:55:32 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     Yuval.Mintz@...gic.com, Ariel.Elior@...gic.com,
        everest-linux-l2@...gic.com, Ram.Amrani@...iumnetworks.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] qed: fix old-style function definition

From: Arnd Bergmann <arnd@...db.de>
Date: Mon, 10 Oct 2016 13:59:16 +0200

> The definition of qed_get_rdma_ops() is not a prototype unless
> we add 'void' here, as indicated by this W=1 warning:
> 
> drivers/net/ethernet/qlogic/qed/qed_roce.c: In function ‘qed_get_rdma_ops’:
> drivers/net/ethernet/qlogic/qed/qed_roce.c:2950:28: error: old-style function definition [-Werror=old-style-definition]
> 
> Fixes: abd49676c707 ("qed: Add RoCE ll2 & GSI support")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Again, Qlogic folks, please properly review patches posted against your
driver.

Thanks.