netdev - RE: [PATCH] qed: fix old-style function definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BL2PR07MB230694B607619C4DFBB90B7F8DDC0@BL2PR07MB2306.namprd07.prod.outlook.com>
Date:   Thu, 13 Oct 2016 14:15:51 +0000
From:   "Mintz, Yuval" <Yuval.Mintz@...ium.com>
To:     David Miller <davem@...emloft.net>, "arnd@...db.de" <arnd@...db.de>
CC:     "Yuval.Mintz@...gic.com" <Yuval.Mintz@...gic.com>,
        "Ariel.Elior@...gic.com" <Ariel.Elior@...gic.com>,
        "everest-linux-l2@...gic.com" <everest-linux-l2@...gic.com>,
        "Amrani, Ram" <Ram.Amrani@...ium.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] qed: fix old-style function definition

> > The definition of qed_get_rdma_ops() is not a prototype unless we add
> > 'void' here, as indicated by this W=1 warning:
> >
> > drivers/net/ethernet/qlogic/qed/qed_roce.c: In function ‘qed_get_rdma_ops’:
> > drivers/net/ethernet/qlogic/qed/qed_roce.c:2950:28: error: old-style
> > function definition [-Werror=old-style-definition]
> >
> > Fixes: abd49676c707 ("qed: Add RoCE ll2 & GSI support")
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> 
> Again, Qlogic folks, please properly review patches posted against your driver.
> 
> Thanks.

Sorry, managed to miss this one.
Acked-by: Yuval Mintz <Yuval.Mintz@...iumnetworks.com>