netdev - Re: [PATCH] net: qcom/emac: disable interrupts before calling phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161015.173506.1915898679977419991.davem@davemloft.net>
Date:   Sat, 15 Oct 2016 17:35:06 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     timur@...eaurora.org
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] net: qcom/emac: disable interrupts before calling
 phy_disconnect

From: Timur Tabi <timur@...eaurora.org>
Date: Fri, 14 Oct 2016 14:14:35 -0500

> There is a race condition that can occur if EMAC interrupts are
> enabled when phy_disconnect() is called.  phy_disconnect() sets
> adjust_link to NULL.  When an interrupt occurs, the ISR might
> call phy_mac_interrupt(), which wakes up the workqueue function
> phy_state_machine().  This function might reference adjust_link,
> thereby causing a null pointer exception.
> 
> Signed-off-by: Timur Tabi <timur@...eaurora.org>

Applied.